This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added support to deserialize JSON (!= NDJSON) #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 70.98% 70.97% -0.02%
==========================================
Files 313 313
Lines 16919 16936 +17
==========================================
+ Hits 12010 12020 +10
- Misses 4909 4916 +7
Continue to review full report at Codecov.
|
jorgecarleitao
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the crate only supported reading NDJSON (by splitting the file with
\nand reading it in chunks). This PR adds support to deserialize JSON.It also adds an example demonstrating how to use it.
It also enables reading arrays with structs (missed by #750)
Closes #712